[PATCH] D65693: [driver][riscv] Support riscv64-linux-gnu multiarch paths

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 6 07:37:44 PDT 2019


asb requested changes to this revision.
asb added a comment.
This revision now requires changes to proceed.

Many thanks for the patch. Could you please add some tests for this behaviour? I imagine you'll want to add a new directory in test/Driver/Inputs with a Debian tree skeleton. See D63497 <https://reviews.llvm.org/D63497> for a relevant example.

Also, when submitting patches please try to generate the patch with -U99999 (see here <https://llvm.org/docs/Phabricator.html#phabricator-request-review-web>) so we can see full context in the Phabricator Web UI.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65693/new/

https://reviews.llvm.org/D65693





More information about the cfe-commits mailing list