[PATCH] D65690: [clang-doc] Add index in each info html file

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 5 17:10:32 PDT 2019


juliehockett added inline comments.


================
Comment at: clang-tools-extra/clang-doc/Generators.cpp:79
+
+bool Generator::createResources(ClangDocContext &CDCtx) {
+  std::error_code OK;
----------------
Why is this implementation in the generic Generator? It's fairly HTML-specific -- neither of the other generators are able to parse and include Javascript (since this does include the `var JsonIndex` bit).


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:665
+    return false;
+  llvm::outs() << "Generating assets for docs...\n";
+  for (const auto &FilePath : CDCtx.UserStylesheets)
----------------
Can we move this to `ClangDocMain.cpp` right above where the function is called? That's where most of these types of status updates are.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65690/new/

https://reviews.llvm.org/D65690





More information about the cfe-commits mailing list