[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 5 03:10:36 PDT 2019


hokein added a comment.

thanks for the detailed comments!



================
Comment at: clang-tools-extra/clangd/test/request-reply.test:22
+---
+{"jsonrpc":"2.0","id":0,"result":{"applied":false}}
+#      CHECK:  "code": -32001,
----------------
sammccall wrote:
> please use increasing IDs and don't reuse them. (In general, but particularly in this test)
I believe `0` is right here, this is a client reply for the server request `0` (applyEdit).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65387/new/

https://reviews.llvm.org/D65387





More information about the cfe-commits mailing list