[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 5 01:37:58 PDT 2019


ilya-biryukov added a comment.

The fix looks good.



================
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:17
 // syntactic and semantic form.
 class InitListExprPreOrderVisitor
     : public ExpectedLocationVisitor<InitListExprPreOrderVisitor> {
----------------
Could you create a new test?
This test is clearly meant to test only `InitListExpr`, we should keep it focused on one thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65735/new/

https://reviews.llvm.org/D65735





More information about the cfe-commits mailing list