[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 3 18:31:12 PDT 2019


plotfi added a comment.

In D65704#1613688 <https://reviews.llvm.org/D65704#1613688>, @compnerd wrote:

> Rather than silently ignoring tests when the DirectoryWatcher isn't created, can you please print an error message and exit with an error code to indicate the test failed?


llvm::Expected requires consumption.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65704/new/

https://reviews.llvm.org/D65704





More information about the cfe-commits mailing list