[PATCH] D65628: [clang-doc] Parallelize reducing phase

[Jake Ehrlich via Phabricator via cfe-commits]

jakehehrlich added a comment.

LGTM other than a couple atomicity issues.



================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:244
+          llvm::errs() << toString(ReadInfos.takeError()) << "\n";
+          Error = true;
+          return;
----------------
use std::atomic<bool>


================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:262
+        llvm::errs() << toString(InfoPath.takeError()) << "\n";
+        Error = true;
+        return;
----------------
This isn't technically thread safe. Use an std::atomic<bool>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65628/new/

https://reviews.llvm.org/D65628