[PATCH] D65634: [RISCV] Default to lp64d in 64-bit RISC-V Linux
Sam Elliott via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 2 02:22:25 PDT 2019
lenary added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:385
+ ? "ilp32"
+ : Triple.getOS() == llvm::Triple::Linux ? "lp64d" : "lp64";
}
----------------
Please may you turn this into a set of if-statements? Nesting ternary operators is a recipe for confusion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65634/new/
https://reviews.llvm.org/D65634
More information about the cfe-commits
mailing list