[PATCH] D65574: Added hack to prevent toHalfOpenFileRange assertion fail
Shaurya Gupta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 2 04:17:37 PDT 2019
SureYeaah marked an inline comment as done.
SureYeaah added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:314
while (!FileRange.getBegin().isFileID()) {
- assert(!FileRange.getEnd().isFileID() &&
- "Both Begin and End should be MacroIDs.");
+ // FIXME: Investigate when this assert fails. Added a hack until then.
+ // assert(!FileRange.getEnd().isFileID() &&
----------------
sammccall wrote:
> We have a reproducer, why can't we investigate now?
Doing that. Just wanted to stop the crashes in the meanwhile.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65574/new/
https://reviews.llvm.org/D65574
More information about the cfe-commits
mailing list