[PATCH] D65582: IR: accept and print numbered %N names for function args

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 10:44:34 PDT 2019


rnk added a comment.

This is awesome! Thanks for doing the test updates. As I read it, LLVM will still read old-style IR just fine, which seems nice.

I think it would be worth noting this in the 10.0 release notes, since it will affect someone upgrading a frontend as you mention.

Otherwise, I think this is basically good to go, unless I'm forgetting anything...

celebration_balloons <https://reviews.llvm.org/file/data/tm7ou3s77zvqrbbjaiva/PHID-FILE-zaivk3z6mlfo6rofz52s/meme-celebration_balloons.gif>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65582/new/

https://reviews.llvm.org/D65582





More information about the cfe-commits mailing list