[PATCH] D65405: [Parser] Use special definition for pragma annotations

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 31 21:18:05 PDT 2019


rjmccall added a comment.

LGTM, although I don't think it would be ridiculous to make this an inline function definition like `isAnnotation`.  (I like your generated implementation much better than the sequential `if`s used there, though.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65405/new/

https://reviews.llvm.org/D65405





More information about the cfe-commits mailing list