[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 31 10:23:54 PDT 2019


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

LG, though I'm obviously not an expert here. Thanks for tracking this down!



================
Comment at: clang/lib/Lex/PPDirectives.cpp:2405
+  auto _ = llvm::make_scope_exit([&]() {
+    // The flag indicates if we have already reached 'eod'.
+    if (CurLexer->ParsingPreprocessorDirective)
----------------
nit: "if we are still waiting for eod"? (to avoid inverting the sense)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65517/new/

https://reviews.llvm.org/D65517





More information about the cfe-commits mailing list