[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

[Haojian Wu via Phabricator via cfe-commits]

hokein updated this revision to Diff 212586.
hokein marked 11 inline comments as done.
hokein added a comment.

address comments:

- move the reply callback handling code to MessageHandler;
- prevent memory leakage when LSP clients don't send back the reply;
- use the new machanism for applyTweak and apply fix;
- update all relevant tests;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65387/new/

https://reviews.llvm.org/D65387

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdLSPServer.h
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/test/code-action-request.test
  clang-tools-extra/clangd/test/execute-command.test
  clang-tools-extra/clangd/test/fixits-command.test
  clang-tools-extra/clangd/test/tweaks-format.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65387.212586.patch
Type: text/x-patch
Size: 15314 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190731/b8543258/attachment-0001.bin>