[PATCH] D65487: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus created this revision.
Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, dcoughlin.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity.

Do you remember the teaser in D65378 <https://reviews.llvm.org/D65378>?

When you think about this, it makes sense. If something is really important, we're tracking it anyways, and that system is sophisticated enough to mark actually interesting statements as such. I wouldn't say that it's even //likely// that subexpressions are also interesting (`array[10 - x + x]`), so I guess even if this produced any effects, its probably undesirable.

---

I originally started working on this refactoring effort to dig from the point where diagnostics construction starts, down to this part of the code. Turns out it doesn't do anything. In fact, after the analysis ends, only visitors may mark objects as interesting (which has any actual effect), which is AMAZING to know, because `ConditionBRVisitor` only has interestiness to work with when it constructs a diagnostics piece.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65487

Files:
  clang/lib/StaticAnalyzer/Core/BugReporter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65487.212459.patch
Type: text/x-patch
Size: 6200 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190730/4b231879/attachment-0001.bin>