[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 29 20:49:09 PDT 2019


xazax.hun added a comment.

I like the change.



================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:630
+        (const RegionBindings::TreeTy *)((uintptr_t)store & ~(uintptr_t)1),
+        RBFactory.getTreeFactory(), (bool)((uintptr_t)store & (uintptr_t)1));
   }
----------------
baloghadamsoftware wrote:
> `(uintptr_t)1` look like a bit like some kind of magic number. Could we define it as a constant instead?
Or maybe this can be abstracted away using `llvm::PointerIntPair`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65361/new/

https://reviews.llvm.org/D65361





More information about the cfe-commits mailing list