r367271 - [DependencyCollector] Make maybeAddDependency virtual (NFC)

Jonas Devlieghere via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 29 16:02:11 PDT 2019


Author: jdevlieghere
Date: Mon Jul 29 16:02:11 2019
New Revision: 367271

URL: http://llvm.org/viewvc/llvm-project?rev=367271&view=rev
Log:
[DependencyCollector] Make maybeAddDependency virtual (NFC)

Make DependencyCollector::maybeAddDependency, just like its other
methods, which I made virtual a while ago. The motivation for this
change is still the LLDB reproducer.

Modified:
    cfe/trunk/include/clang/Frontend/Utils.h

Modified: cfe/trunk/include/clang/Frontend/Utils.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/Utils.h?rev=367271&r1=367270&r2=367271&view=diff
==============================================================================
--- cfe/trunk/include/clang/Frontend/Utils.h (original)
+++ cfe/trunk/include/clang/Frontend/Utils.h Mon Jul 29 16:02:11 2019
@@ -99,11 +99,11 @@ public:
   /// Return true if system files should be passed to sawDependency().
   virtual bool needSystemDependencies() { return false; }
 
-  // implementation detail
   /// Add a dependency \p Filename if it has not been seen before and
   /// sawDependency() returns true.
-  void maybeAddDependency(StringRef Filename, bool FromModule, bool IsSystem,
-                          bool IsModuleFile, bool IsMissing);
+  virtual void maybeAddDependency(StringRef Filename, bool FromModule,
+                                  bool IsSystem, bool IsModuleFile,
+                                  bool IsMissing);
 
 protected:
   /// Return true if the filename was added to the list of dependencies, false




More information about the cfe-commits mailing list