[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 29 12:10:13 PDT 2019


efriedma added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
   switch (BuiltinID) {
   default: return nullptr;
   case NEON::BI__builtin_neon_vbsl_v:
----------------
I'm a little concerned about the overall code structure here; even if moving the code for the MSVC builtins is enough to fix those builtins specifically, is it actually impossible to hit this "default"?  If it is, can we convert it to an "unreachable"?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65403/new/

https://reviews.llvm.org/D65403





More information about the cfe-commits mailing list