[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 29 07:37:15 PDT 2019


gribozavr accepted this revision.
gribozavr added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:7095
       auto *MTE = dyn_cast<MaterializeTemporaryExpr>(L);
+      if (IsGslPtrInitWithGslTempOwner) {
+        Diag(DiagLoc, diag::warn_dangling_lifetime_pointer) << DiagRange;
----------------
It is unclear to me why `if (IsGslPtrInitWithGslTempOwner)` is before `if (!MTE)`, seems like that exclusion should apply to our case, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64256/new/

https://reviews.llvm.org/D64256





More information about the cfe-commits mailing list