[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

[Richard Musil via Phabricator via cfe-commits]

risa2000 added inline comments.


================
Comment at: clang/lib/Headers/CMakeLists.txt:190
 
+if(CMAKE_CONFIGURATION_TYPES)
+  string(REPLACE "${CMAKE_CFG_INTDIR}" "$<CONFIG>" output_dir "${output_dir}")
----------------
beanz wrote:
> I think this will break Xcode
I guess I put it in since it seemed to be already used around:

```
$ grep -r "if(CMAKE_CONFIGURATION_TYPES)" *
compiler-rt/cmake/Modules/AddCompilerRT.cmake:  if(CMAKE_CONFIGURATION_TYPES)
compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:    if(CMAKE_CONFIGURATION_TYPES)
compiler-rt/CMakeLists.txt:if(CMAKE_CONFIGURATION_TYPES)
lldb/utils/lldb-dotest/CMakeLists.txt:  if(CMAKE_CONFIGURATION_TYPES)
llvm/cmake/modules/AddLLVM.cmake:    if(CMAKE_CONFIGURATION_TYPES)
llvm/cmake/modules/AddLLVM.cmake:    if(CMAKE_CONFIGURATION_TYPES)
llvm/cmake/modules/CrossCompile.cmake:  if(CMAKE_CONFIGURATION_TYPES)

```
but technically, the generator expression should work equally for single and multi-config generators, so the condition is not necessary. What exactly will break Xcode?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65270/new/

https://reviews.llvm.org/D65270