[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Fri Jul 26 14:46:53 PDT 2019

tmroeder marked an inline comment as done.
tmroeder added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include <c++/8/bits/c++config.h>
+
----------------
tmroeder wrote:
> nickdesaulniers wrote:
> > tmroeder wrote:
> > > lebedev.ri wrote:
> > > > This looks wrong
> > > Yeah, I'm not sure where that came from. I'll remove it.
> > Hard to tell, but I don't think this `using` statement was ever removed as requested?
> It's not the "using" statement that was requested to be removed in the initial diff, but rather "#include <c++/8/bits/c++config.h>", which I did remove.
> 
> I'm not sure why the "This looks wrong" gets attached to the "using" statement in later diffs.
Nick, can you confirm that this addresses your comment?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59963/new/

https://reviews.llvm.org/D59963