[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 26 06:30:13 PDT 2019


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:168
     std::lock_guard<std::mutex> Lock(Mutex);
+    CachedCDB *Entry;
     if (CompileCommandsDir) {
----------------
nit: set default `nullptr`.


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:210
   if (CompileCommandsDir) {
     assert(*CompileCommandsDir == Result.PI.SourceRoot &&
            "Trying to broadcast a CDB outside of CompileCommandsDir!");
----------------
should we use the `pathEqual` here too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65320/new/

https://reviews.llvm.org/D65320





More information about the cfe-commits mailing list