[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

Shaurya Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 26 03:29:47 PDT 2019


SureYeaah added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:448
+
+          // Binary subexpressions
+          {R"cpp(void f() {
----------------
sammccall wrote:
> SureYeaah wrote:
> > Can we have some tests with macros as well?
> Added a simple one that just verifies we support operands being wrapped in macros, but not operators.
Isn't it the same behavior in both cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65139/new/

https://reviews.llvm.org/D65139





More information about the cfe-commits mailing list