[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

[Elaina Guan via Phabricator via cfe-commits]

ziyig added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:1172
       return ExprError();
+    LLVM_FALLTHROUGH;
+  case Builtin::BI__builtin_alloca:
----------------
aaron.ballman wrote:
> Do we want to warn on all uses of alloca(), or just the ones that get past the call to `SemaBuiltinAllocaWithAlign()`?
I don't have strong opinion about this. Which one do you think is better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64883/new/

https://reviews.llvm.org/D64883