[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Oops, forgot to hit send.



================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:430
+  if (llvm::outs().is_displayed() && llvm::errs().is_displayed())
+    llvm::errs() << Overview << "\n";
   // Use buffered stream to stderr (we still flush each log message). Unbuffered
----------------
hokein wrote:
> do we want to exit clangd for this case?
I'd prefer not to, it's only "somewhat likely" the user is confused - there's a chance they're going to e.g. paste in LSP messages.

Also behaving *completely* differently when connected to a TTY violates expectations and can make debugging hard. Changing the log output seems fine, refusing to speak the protocol doesn't.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65201/new/

https://reviews.llvm.org/D65201