[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

Wed Jul 24 12:03:57 PDT 2019

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!

================
Comment at: clang/include/clang/Driver/Types.def:39-45
+// Some of the options in Flags have been removed, so far those are:
+//  a - The type should only be assembled: Now, check that Phases contains
+//      phases::Assemble but not phases::Compile or phases::Backend.
+//  p - The type should only be precompiled: Now, check that Phases contains
+//      phases::Precompile but that Flags does not contain 'm'.
+//  m - Precompiling this type produces a module file: Now, check that
+//      isPrepeocessedModuleType.
----------------
compnerd wrote:
> aaron.ballman wrote:
> > Why should we document the removed flags, since users cannot write them anyway?
> Actually, that makes sense to me.  The reasoning for it (and the key thing to note about the documentation) is that it helps downstream forks as it indicates how to migrate.  Now, if you believe that this bit of functionality is unlikely to be used, thats a different story.  But, I don't think that it hurts to have the documentation in the commit message instead.
Okay, that makes sense to me. Thank you for the explanation!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65176/new/

https://reviews.llvm.org/D65176