[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 24 04:25:37 PDT 2019
aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Driver/Types.def:39-45
+// Some of the options in Flags have been removed, so far those are:
+// a - The type should only be assembled: Now, check that Phases contains
+// phases::Assemble but not phases::Compile or phases::Backend.
+// p - The type should only be precompiled: Now, check that Phases contains
+// phases::Precompile but that Flags does not contain 'm'.
+// m - Precompiling this type produces a module file: Now, check that
+// isPrepeocessedModuleType.
----------------
Why should we document the removed flags, since users cannot write them anyway?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65176/new/
https://reviews.llvm.org/D65176
More information about the cfe-commits
mailing list