[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet.
Herald added a project: clang.
NoQ added a parent revision: D64274: [analyzer] VirtualCallChecker overhaul..

- Mention the name of the virtual function. This should help when the warning appears in a complicated expression and it's unclear what part of the expression it is about.
- Calling a pure virtual function always sinks the analysis, even if the checker is not in pure-only mode.
- Refactor/modernize the code a bit.


Repository:
  rC Clang

https://reviews.llvm.org/D65180

Files:
  clang/lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
  clang/test/Analysis/virtualcall.cpp
  clang/test/Analysis/virtualcall.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65180.211396.patch
Type: text/x-patch
Size: 8406 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190724/ac1cb044/attachment.bin>