[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 23 07:27:46 PDT 2019


balazske marked an inline comment as done.
balazske added inline comments.


================
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:175
+  /// returned.
+  llvm::Optional<std::pair<SourceLocation /*FromLoc*/, ASTUnit *>>
+  getImportedFromSourceLocation(const clang::SourceLocation &ToLoc) const;
----------------
It would be better to use `std::tuple<SourceLocation, Preprocessor &, ASTContext &>` here. (Or * if & does not work.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65064/new/

https://reviews.llvm.org/D65064





More information about the cfe-commits mailing list