[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 23 05:04:26 PDT 2019


aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

In D64666#1596660 <https://reviews.llvm.org/D64666#1596660>, @xbolva00 wrote:

> I think we should warn in that case even if GCC does not warn.


Strong +1.

In D64666#1596853 <https://reviews.llvm.org/D64666#1596853>, @ziangwan wrote:

> Final review ping.


Please be sure to give reviewers enough time to respond to comments before pinging a review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666





More information about the cfe-commits mailing list