[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051
+  // Claim flags for the integrated assembler only if it's being used.
+  if (IsIntegratedAs) {
+    if (UseRelaxAll(C, Args))
----------------
thakis wrote:
> nickdesaulniers wrote:
> > thakis wrote:
> > > (This just wraps all the red lines on the lhs in an `if (IsIntegratedAs)` and leaves them all otherwise unchanged.)
> > Return early on negated condition instead of adding additional indentation and messing with `git blame`.
> It doesn't skip the whole function, just the first few flags.
oic


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65108/new/

https://reviews.llvm.org/D65108