[PATCH] D65100: [clangd] Fix SelectionTree traversal of qualified types
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 22 09:27:22 PDT 2019
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
QualifiedTypeLoc isn't treated like a regular citizen by RecursiveASTVisitor.
This meant we weren't intercepting the traversal of its inner TypeLoc.
Most of the changes here are about exposing kind() so we can improve the
precision of our tests.
This should fix the issue raised in D65067 <https://reviews.llvm.org/D65067>.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D65100
Files:
clang-tools-extra/clangd/Selection.cpp
clang-tools-extra/clangd/Selection.h
clang-tools-extra/clangd/unittests/SelectionTests.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65100.211130.patch
Type: text/x-patch
Size: 6143 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190722/289e1c08/attachment-0001.bin>
More information about the cfe-commits
mailing list