[PATCH] D64780: Disallow most calling convention attributes on PS4.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 08:02:43 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a nit. You should give other reviewers a chance to sign off in case they have additional comments.



================
Comment at: lib/Basic/Targets/OSTargets.h:564
   }
+  TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override {
+    return (CC == CC_C) ? TargetInfo::CCCR_OK : TargetInfo::CCCR_Error;
----------------
Line length seems a bit long for coding style requirements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64780/new/

https://reviews.llvm.org/D64780





More information about the cfe-commits mailing list