[PATCH] D64863: [clangd] Ignore diags from builtin files
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 19 07:09:32 PDT 2019
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:601
- if (mentionsMainFile(*LastDiag) ||
- (LastDiag->Severity >= DiagnosticsEngine::Level::Error &&
- IncludeLinesWithErrors.insert(LastDiag->Range.start.line).second)) {
----------------
It's not clear why we these conditions should be checked somewhere else.
Could you explain in more detail?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64863/new/
https://reviews.llvm.org/D64863
More information about the cfe-commits
mailing list