[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

`StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`:

  add_clang_library(clangStaticAnalyzerCore
  ...
    LINK_LIBS
    clangAST
    clangASTMatchers
    clangAnalysis
    clangBasic
    clangCrossTU
    clangLex
    clangRewrite
    )

Not a `StaticAnalyzer` expert, so I don't know whether it's acceptable to add this dependency to `clangStaticAnalyzerCore`, you'll have to find someone who owns the code to know whether this dependency is justified.
(My wild guess from looking at the names of the libraries would be that this dependency is not ok and the code should go into `clangStaticAnalyzerFrontend` instead. But again, not an expert here, just a guess).

But please add a dependency into `LINK_LIBS` inside `CMakeLists.txt` if you start depending on `clangFrontend`.
Most of these violations are found if you build in a `cmake -DBUILD_SHARED_LIBS=On` configuration.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64638/new/

https://reviews.llvm.org/D64638