[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Awesome, I think this is in better shape than before highlighting was added.



================
Comment at: clang-tools-extra/clangd/TUScheduler.h:102
                              const CanonicalIncludes &) {}
+  /// The argument function is run under the critical section guarding against
+  /// races when closing the files.
----------------
uber-nit: newline before this, as currently it's grouped with onPreambleAST rather than onMainAST


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64985/new/

https://reviews.llvm.org/D64985