[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 04:10:07 PDT 2019


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:399
+          // FIXME: SelectionTree needs to be fixed for macros
+          /*{R"cpp(#define LOOP(x) while (1) {a = x;}
                  void f(int a) {
----------------
can you uncomment this case, and assert the actual behavior? The FIXME should say what it should be instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64329/new/

https://reviews.llvm.org/D64329





More information about the cfe-commits mailing list