[PATCH] D64592: [OpenMP] Fix target link implementation

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 12:15:41 PDT 2019


ABataev added a comment.

Fix the name of the patch. It is the patch for declare target, not target.



================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2598-2599
+                                 DeviceID, FileID, Line);
+      OS << CGM.getMangledName(GlobalDecl(VD))
+         << llvm::format("_%x", FileID) << "_decl_tgt_ref_ptr";
     }
----------------
Why do you want to add to zeroed FileId for externally visible vars? Leave them as-is.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64592/new/

https://reviews.llvm.org/D64592





More information about the cfe-commits mailing list