[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

Thu Jul 18 08:39:05 PDT 2019

yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:4973-4992
   case CudaArch::GFX600:
   case CudaArch::GFX601:
   case CudaArch::GFX700:
   case CudaArch::GFX701:
   case CudaArch::GFX702:
   case CudaArch::GFX703:
   case CudaArch::GFX704:
----------------
tra wrote:
> Just a side note: 
> I wonder if we need these at all -- we'll end up failing with misleading "Unexpected NVPTX target without ptx feature" assertion. We may just remove all non-SM_xx arch cases and replace them with default: calling llvm_unreachable(). Perhaps in a separate patch.
> 
I think it is intentional not to use default here, otherwise people may forget to update this part when a new nvptx arch is added.

I could let gfx archs go to the path with llvm_unreachable("Unexpected Cuda arch.") though.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64364/new/

https://reviews.llvm.org/D64364