[PATCH] D64915: [clangd] cleanup: unify the implemenation of checking a location is inside main file.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:448
+  };
+  for (const auto *HeaderDecl : {"Header1", "Header2", "Header3"})
+    EXPECT_FALSE(isInsideMainFile(DeclLoc(HeaderDecl), SM));
----------------
NIT: not sure if it's easy to get a hold of those, but ...
maybe add tests for locations inside the `<builtin>`, `<command-line>` and `<scratch>` buffers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64915/new/

https://reviews.llvm.org/D64915