[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Thu Jul 18 05:22:09 PDT 2019

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

In D55044#1589496 <https://reviews.llvm.org/D55044#1589496>, @alexfh wrote:

> Seems good now. Haojian, do you have any concerns?

sorry for the looong delay, I totally miss this thread. looks good from my side, you'd need to rebase the patch to master.

================
Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:22
+The Abseil Style Guide <https://abseil.io/tips/126>_ discusses this issue in
+more detail.
----------------
I think we should expose the `MakeSmartPtrFunctionHeader` to the document, this option is used to configure the absl memory header.

================
Comment at: test/clang-tidy/abseil-make-unique.cpp:1
+// RUN: %check_clang_tidy %s abseil-make-unique %t -- -- -std=c++11 \
+// RUN:   -I%S/Inputs/modernize-smart-ptr
----------------
nit: drop the `-std=c++11`, check_clang_tidy.py will add it by default.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044