[PATCH] D64712: [clangd] Refactor background-index shard loading
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 03:02:52 PDT 2019
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/Background.cpp:490
+ auto FS = FSProvider.getFileSystem();
+ llvm::DenseSet<PathRef> TUsToIndex;
+ for (auto &SI : Result.Shards) {
----------------
sammccall wrote:
> nit: again, this patch is adding Path/PathRef aliases to parts of the code that don't use them
I believe they represent the intention better then `string/StringRef`that was the reason I was using them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64712/new/
https://reviews.llvm.org/D64712
More information about the cfe-commits
mailing list