[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 18 00:01:32 PDT 2019
aaron.ballman added inline comments.
================
Comment at: clang/lib/Driver/Types.cpp:305
+ P.clear();
+ for (auto Phase : getInfo(Id).Phases)
+ P.push_back(Phase);
----------------
Can't you use the local `Phases` object instead of calling `getInfo()` again? This seems like it wants to be `P = Phases;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64098/new/
https://reviews.llvm.org/D64098
More information about the cfe-commits
mailing list