[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units
Gheorghe-Teodor Bercea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 17 12:17:12 PDT 2019
gtbercea marked an inline comment as done.
gtbercea added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2610
+ auto *GV = cast<llvm::GlobalVariable>(Ptr);
+ GV->setLinkage(llvm::GlobalValue::WeakAnyLinkage);
+
----------------
ABataev wrote:
> Better to fix the link clause processing in a different patch, it has nothing to do with the unified memory.
Sure I can split this patch.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64592/new/
https://reviews.llvm.org/D64592
More information about the cfe-commits
mailing list