[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

I have one small question otherwise looks good.



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1457
+  if (TKind == TrackingKind::ConditionTracking &&
+      StoreSite->getStackFrame() == OriginSFC)
+    return nullptr;
----------------
I wonder if "nested" is a good term in the title of this revision. We could also show notes in the caller right? So it might also be an "enclosing" frame. And if so, is it desired? Since the "enclosing" frames should already be visible for the user without the additional notes. But correct me if I'm wrong :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64272/new/

https://reviews.llvm.org/D64272