[PATCH] D64780: Disallow most calling convention attributes on PS4.

[Warren Ristow via Phabricator via cfe-commits]

wristow added reviewers: rnk, rjmccall.
wristow added inline comments.


================
Comment at: include/clang/Basic/TargetInfo.h:1271
     CCCR_Ignore,
+    CCCR_Error,
   };
----------------
rnk wrote:
> I feel like perhaps a cleaner way of implementing this would be to have the driver pass down -Werror=unknown-calling-conv (sp) on PS4. That would also allow users to tell clang to ignore their CC annotations by disabling the warning, which could be useful when porting a codebase widely annotated with __stdcall, for example.
I can see the value of allowing users to ignore the CC annotations to ease a porting task, but we on PS4 prefer not to allow that.  We're probably more cautious than most about ABI incompatibilities, so if others decide to restrict use of unsupported CCs, they may very well want to go this route of the driver disabling the CCs.  But we'll still make them hard errors on PS4.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64780/new/

https://reviews.llvm.org/D64780