[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 17 07:56:33 PDT 2019


lebedev.ri added a comment.

Is there sufficient test coverage as to what happens if `SortPriority` is not set?



================
Comment at: lib/Format/Format.cpp:455-456
                    Style.KeepEmptyLinesAtTheStartOfBlocks);
-    IO.mapOptional("BitFieldDeclarationsOnePerLine", Style.BitFieldDeclarationsOnePerLine);
+    IO.mapOptional("BitFieldDeclarationsOnePerLine",
+                   Style.BitFieldDeclarationsOnePerLine);
     IO.mapOptional("MacroBlockBegin", Style.MacroBlockBegin);
----------------
Unrelated change


================
Comment at: lib/Format/Format.cpp:613-614
   Expanded.BraceWrapping = {false, false, false, false, false, false,
-                            false, false, false, false, false,
-                            false, false, true,  true,  true};
+                            false, false, false, false, false, false,
+                            false, true,  true,  true};
   switch (Style.BreakBeforeBraces) {
----------------
Unrelated change


================
Comment at: lib/Format/Format.cpp:692-693
   LLVMStyle.BraceWrapping = {false, false, false, false, false, false,
-                             false, false, false, false, false,
-                             false, false, true,  true,  true};
+                             false, false, false, false, false, false,
+                             false, true,  true,  true};
   LLVMStyle.BreakAfterJavaFieldAnnotations = false;
----------------
Unrelated change


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64695/new/

https://reviews.llvm.org/D64695





More information about the cfe-commits mailing list