[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

Tue Jul 16 13:56:53 PDT 2019

vitalybuka marked an inline comment as done.
vitalybuka added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:27
+static const char GlobalArgumentMemAccess[] = {
+// grep  -P -o "(?<=FUNCTION_INFO: ).*" <logfile> | sort -u >
+// ../llvm-project/llvm/lib/Transforms/Scalar/DeadStoreEliminationExpData.h
----------------
glider wrote:
> vitalybuka wrote:
> > glider wrote:
> > > Ditto.
> > These files should be empty. Raw diff https://reviews.llvm.org/file/data/o6sk6gw2gqs4u4pmodrn/PHID-FILE-s6c6nsofxnqekkcvzdzs/D61879.diff already contains them. 
> > It's ThinLTO replacement experiments. They don't improve results enough, so I didn't bother to create real ThinLTO stuff. Anyway it is not needed for full LTO.
> > 
> ```
> $ ninja -j64 check-clang
> ...
> /usr/local/google/src/llvm-git-monorepo/llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:20:32: error: zero-size array ‘llvm::GUIDS_LOOKUP’
>  static const GlobalValue::GUID GUIDS_LOOKUP[] = {
>                                 ^~~~~~~~~~~~
> /usr/local/google/src/llvm-git-monorepo/llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:26:19: error: zero-size array ‘llvm::GlobalArgumentMemAccess’
>  static const char GlobalArgumentMemAccess[] = {
>                    ^~~~~~~~~~~~~~~~~~~~~~~
> ```
> Am I doing something wrong? Looks like empty files aren't enough.
> I've fixed the problem by putting "0" into each file, but it's strange it works differently for us.
You must be using LLVM_ENABLE_WERROR?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61879/new/

https://reviews.llvm.org/D61879