[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 11:32:48 PDT 2019


lebedev.ri added reviewers: JonasToth, gribozavr.
lebedev.ri added a comment.

Thanks.
Are there any tests missing for `volatile`, atomics?
I'm not really current on clang-tidy state of affairs, so i'm gonna leave most of the review for others..



================
Comment at: clang-tidy/bugprone/InfiniteLoopCheck.cpp:21
+static internal::Matcher<Stmt> loopEndingStmt() {
+  return stmt(anyOf(breakStmt(), returnStmt(), gotoStmt(), cxxThrowExpr()));
+}
----------------
What about function calls marked `noreturn`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64736/new/

https://reviews.llvm.org/D64736





More information about the cfe-commits mailing list