[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 10:25:03 PDT 2019


rjmccall added a comment.

Minor comment then LGTM



================
Comment at: lib/Sema/SemaType.cpp:7418
+      // Expect for pointer or reference types because the addr space in
+      // template argument can only belong to a pointee.
+      (T->isDependentType() && !T->isPointerType() && !T->isReferenceType()) ||
----------------
"Except"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62584/new/

https://reviews.llvm.org/D62584





More information about the cfe-commits mailing list