[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 16 02:33:38 PDT 2019
sammccall added a subscriber: klimek.
sammccall added inline comments.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2427-2428
return 50;
+ if (Left.is(TT_UnaryOperator) && Right.is(TT_ObjCMethodExpr))
+ return 60;
----------------
This looks a little suspicious only because it's so specific.
It seems like you'd *always* want a harsh penalty for breaking between a unary operator and its operand. @klimek does this look right, should we drop the `ObcJMethodExpr` requirement or is this case handled elsewhere?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64775/new/
https://reviews.llvm.org/D64775
More information about the cfe-commits
mailing list