[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

Mon Jul 15 10:39:35 PDT 2019

nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

I verified the conversion values are correct in the precise warnings in the test cases.  From that perspective, and the rest of the code LGTM.  Please wait for review from another reviewer.  Thanks for the patch.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:11426
+        // during the whole conversion.
+        // TODO: This operation is costly.
+        llvm::APFloat TargetFloatValue(
----------------
This TODO doesn't add information about what to fix in the future.  I think it's ok to remove, as its understood that additional levels of semantic analysis is costlier and costlier.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666